On Mon, Nov 24, 2014 at 12:04:11PM +0000, Andre Przywara wrote: > Hej Christoffer, > > On 24/11/14 09:41, Christoffer Dall wrote: > > When 'injecting' an edge-triggered interrupt with a falling edge we > > shouldn't clear the pending state on the distributor. In fact, we > > don't, because the check in vgic_validate_injection would prevent us > > from ever reaching this bit of code. > > > > Remove the unreachable snippet. > > > > Signed-off-by: Christoffer Dall <christoffer.dall@xxxxxxxxxx> > > Acked-by: Andre Przywara <andre.przywara@xxxxxxx> > > I agree on this. Would it make sense to rewrite this function a bit to > make it more clearer what happens? I find the nesting of the > if-statements counter-intuitive: I'd prefer to first differentiate > between level and edge triggered and then only check the actual level in > the level-triggered branch. Not sure if it's worth the fuss, though. > I disagree, and it's not ;) -Christoffer _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
