Re: [PATCH v4 13/19] arm/arm64: KVM: split GICv2 specific emulation code from vgic.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 14, 2014 at 10:07:57AM +0000, Andre Przywara wrote:
> vgic.c is currently a mixture of generic vGIC emulation code and
> functions specific to emulating a GICv2. To ease the addition of
> GICv3, split off strictly v2 specific parts into a new file
> vgic-v2-emul.c.
> 
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> Acked-by: Christoffer Dall <christoffer.dall@xxxxxxxxxx>

[...]

> 
> -
> -void vgic_destroy(struct kvm_device *dev)
> -{
> -	kfree(dev);
> -}
> -
> -int vgic_create(struct kvm_device *dev, u32 type)

ah, I see, you make it static again when it magically apappears as vgic_v2_create.

never mind the comment on the last patch.

my ack still stands.

Thanks,
-Christoffer
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm




[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux