Shannon,
On 14/11/14 11:09, Shannon Zhao wrote:
> When call kvm_vgic_inject_irq to inject irq, we've already known
> which vcpu the IRQ for form the cpuid. So we should just kick this
> one vcpu to avoid iterate through all.
>
> Signed-off-by: Shannon Zhao <zhaoshenglong@xxxxxxxxxx>
> ---
> virt/kvm/arm/vgic.c | 18 +++++++++++++++++-
> 1 files changed, 17 insertions(+), 1 deletions(-)
>
> diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c
> index 82db9d6..093f21f 100644
> --- a/virt/kvm/arm/vgic.c
> +++ b/virt/kvm/arm/vgic.c
> @@ -95,6 +95,7 @@ static void vgic_retire_disabled_irqs(struct kvm_vcpu *vcpu);
> static void vgic_retire_lr(int lr_nr, int irq, struct kvm_vcpu *vcpu);
> static void vgic_update_state(struct kvm *kvm);
> static void vgic_kick_vcpus(struct kvm *kvm);
> +static void vgic_kick_vcpu(struct kvm *kvm, int cpuid);
> static u8 *vgic_get_sgi_sources(struct vgic_dist *dist, int vcpu_id, int sgi);
> static void vgic_dispatch_sgi(struct kvm_vcpu *vcpu, u32 reg);
> static struct vgic_lr vgic_get_lr(const struct kvm_vcpu *vcpu, int lr);
> @@ -1589,6 +1590,21 @@ static void vgic_kick_vcpus(struct kvm *kvm)
> }
> }
>
> +static void vgic_kick_vcpu(struct kvm *kvm, int cpuid)
> +{
> + struct kvm_vcpu *vcpu;
> +
> + /*
> + * We've injected an interrupt, kick the specified vcpu
> + */
> + if (cpuid < atomic_read(&kvm->online_vcpus)) {
> + vcpu = kvm_get_vcpu(kvm, cpuid);
> + if (vcpu != NULL) {
> + kvm_vcpu_kick(vcpu);
> + }
> + }
> +}
> +
> static int vgic_validate_injection(struct kvm_vcpu *vcpu, int irq, int level)
> {
> int edge_triggered = vgic_irq_is_edge(vcpu, irq);
> @@ -1694,7 +1710,7 @@ int kvm_vgic_inject_irq(struct kvm *kvm, int cpuid, unsigned int irq_num,
> {
> if (likely(vgic_initialized(kvm)) &&
> vgic_update_irq_pending(kvm, cpuid, irq_num, level))
> - vgic_kick_vcpus(kvm);
> + vgic_kick_vcpu(kvm, cpuid);
>
> return 0;
> }
>
Have you actually tested this? Hint: cpuid is *not* what you think, and
I strongly suggest you play with interrupt affinity in the guest before
posting such changes.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
