On 19.09.14 18:07, Eric Auger wrote: > Hi Stefan, > > Thanks for asking. Actually I think this is a bit early. I would like > some VFIO PCI users experiencing it a little bit (typically Alex) and > confirm they are happy with it. Don't be so reluctant - this patch is a step forward, so just mark it as a real patch. There's nothing controversial in here. > > Also as I mentionned in the commit message, I identified some parsing > issues that forced me to change few format strings. I don't know if you > have time or are willing to fix those - you may be more efficient doing > those fixes than I would;-) - Nethertheless if you can't afford, I will > have a look at the Python code. > > For convenience I put the issues again, all related to parenthesis: > > Cases than are not correctly handled are given below: > - "(%04x:%02x:%02x.%x)" need to be replaced by " (%04x:%02x:%02x.%x)" > - "%s read(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", %d) = 0x%"PRIx64 replaced by > "%s read(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", %d = 0x%"PRIx64 > - "%s write(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", 0x%"PRIx64", %d)" > replaced by > "%s write(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", 0x%"PRIx64", %d" Looks like cosmetic problems that can be solved later :). Alex _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
