On Thu, Sep 11, 2014 at 12:54:38PM -0700, Mario Smarduch wrote:
> On 09/10/2014 08:12 PM, Christoffer Dall wrote:
> > On Tue, Aug 26, 2014 at 05:04:04PM -0700, Mario Smarduch wrote:
> >> Add support for generic implementation of dirty log read function. For now both
> >> x86_64 and ARMv7 share generic dirty log read. Other architectures call
> >> their architecture specific functions.
> >>
> >> Signed-off-by: Mario Smarduch <m.smarduch@xxxxxxxxxxx>
> >> ---
> >> arch/arm/include/asm/kvm_host.h | 2 +
> >> arch/arm/kvm/Kconfig | 1 +
> >> arch/arm/kvm/arm.c | 2 +-
> >> arch/arm64/include/asm/kvm_host.h | 2 +
> >> arch/arm64/kvm/Kconfig | 1 +
> >> arch/ia64/include/asm/kvm_host.h | 1 +
> >> arch/ia64/kvm/Kconfig | 1 +
> >> arch/ia64/kvm/kvm-ia64.c | 2 +-
> >> arch/mips/include/asm/kvm_host.h | 1 +
> >> arch/mips/kvm/Kconfig | 1 +
> >> arch/mips/kvm/mips.c | 2 +-
> >> arch/powerpc/include/asm/kvm_host.h | 2 +
> >> arch/powerpc/kvm/Kconfig | 1 +
> >> arch/powerpc/kvm/book3s.c | 2 +-
> >> arch/powerpc/kvm/booke.c | 2 +-
> >> arch/s390/include/asm/kvm_host.h | 2 +
> >> arch/s390/kvm/Kconfig | 1 +
> >> arch/s390/kvm/kvm-s390.c | 2 +-
> >> arch/x86/kvm/x86.c | 86 -----------------------------------
> >> include/linux/kvm_host.h | 2 +
> >> virt/kvm/Kconfig | 3 ++
> >> virt/kvm/kvm_main.c | 90 +++++++++++++++++++++++++++++++++++++
> >> 22 files changed, 117 insertions(+), 92 deletions(-)
> >>
> >> diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h
> >> index 193ceaf..8fc078d 100644
> >> --- a/arch/arm/include/asm/kvm_host.h
> >> +++ b/arch/arm/include/asm/kvm_host.h
> >> @@ -231,4 +231,6 @@ int kvm_perf_teardown(void);
> >> u64 kvm_arm_timer_get_reg(struct kvm_vcpu *, u64 regid);
> >> int kvm_arm_timer_set_reg(struct kvm_vcpu *, u64 regid, u64 value);
> >>
> >> +int kvm_arch_vm_ioctl_get_dirty_log(struct kvm *kvm, struct kvm_dirty_log *log);
> >> +
> >> #endif /* __ARM_KVM_HOST_H__ */
> >> diff --git a/arch/arm/kvm/Kconfig b/arch/arm/kvm/Kconfig
> >> index 4be5bb1..cd9bb1c 100644
> >> --- a/arch/arm/kvm/Kconfig
> >> +++ b/arch/arm/kvm/Kconfig
> >> @@ -23,6 +23,7 @@ config KVM
> >> select HAVE_KVM_CPU_RELAX_INTERCEPT
> >> select KVM_MMIO
> >> select KVM_ARM_HOST
> >> + select HAVE_KVM_ARCH_DIRTY_LOG
> >> depends on ARM_VIRT_EXT && ARM_LPAE && !CPU_BIG_ENDIAN
> >> ---help---
> >> Support hosting virtualized guest machines. You will also
> >> diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c
> >> index 3c82b37..c52b2bd 100644
> >> --- a/arch/arm/kvm/arm.c
> >> +++ b/arch/arm/kvm/arm.c
> >> @@ -774,7 +774,7 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
> >> }
> >> }
> >>
> >> -int kvm_vm_ioctl_get_dirty_log(struct kvm *kvm, struct kvm_dirty_log *log)
> >> +int kvm_arch_vm_ioctl_get_dirty_log(struct kvm *kvm, struct kvm_dirty_log *log)
> >> {
> >> return -EINVAL;
> >> }
> >
> > you dropped guarding this with CONFIG_ARM64?
>
> Second patch makes x86 generic and all other architecture
> specific. Subsequent patch adds armv7 to generic and also adds
> the guard for arm64.
>
Ah, right, understood.
In that case:
Acked-by: Christoffer Dall <christoffer.dall@xxxxxxxxxx>
Thanks,
-Christoffer
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
