On 09.09.14 17:59, Paolo Bonzini wrote: > Il 09/09/2014 17:25, Eric Auger ha scritto: >>>> >>>> Please provide a wrapper like sysbus_register_dynamic that takes the >>>> params/address_space_mem/mpic as parameter. platform_bus_init_notify >>>> and DynSysbusNotifier can remain hidden within the .c file. >> Sorry I do not catch what you mean here. platform_bus_init_notify & >> DynSysbusNotifier are currently used in virt.c to initialize & register >> the machine_init_done_notifier. > > Yeah, please do the registration in sysbus.c, not in virt.c. There is > no reason to make the platform_bus_init_notify+DynSysbusNotifier > interface public. The code in sysbus.c can fill in the fields. Sysbus != Platform bus. Sysbus is an in-QEMU representation of a pseudo-bus that we put all devices onto that we consider unsorted. Platform bus is a machine representation of an actual bus that devices are attached to. These devices usually are sysbus devices. Alex _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
