Re: [PATCH V2] ARM/ARM64: KVM: Nuke Hyp-mode tlbs before enabling MMU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 






On 22 August 2014 16:11, Marc Zyngier <marc.zyngier@xxxxxxx> wrote:
On 22/08/14 11:23, Mark Rutland wrote:
> Hi Pranav,
>
> On Thu, Jul 31, 2014 at 07:53:23AM +0100, Pranavkumar Sawargaonkar wrote:
>> X-Gene u-boot runs in EL2 mode with MMU enabled hence we might
>> have stale EL2 tlb enteris when we enable EL2 MMU on each host CPU.
>
> Nit: entries
>
>> This can happen on any ARM/ARM64 board running bootloader in
>> Hyp-mode (or EL2-mode) with MMU enabled.
>>
>> This patch ensures that we flush all Hyp-mode (or EL2-mode) TLBs
>> on each host CPU before enabling Hyp-mode (or EL2-mode) MMU.
>
> I hit a similar issue intermittently on a Juno board when I boot Linux
> as an EFI application, where CPU0 would get stuck in a recursive
> exception at EL2 while initialising hyp. We don't nuke the TLBs in
> efi_stub_entry nor do we do so in el2_setup, so there's the possibility
> of stale EL2 TLB entries lying around from UEFI.
>
> With this patch applied I'm unable to reproduce the issue (with ~30
> boots so far). So:
>
> Tested-by: Mark Rutland <mark.rutland@xxxxxxx>
>
> It would be nice to see this hit mainline soon.

Thanks for testing. I guess this is a candidate for stable as well.

Thanks Mark for testing and thanks Marc for review and ack.

        M.
--
Jazz is not dead. It just smells funny...
-
Pranav

_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux