On 07/08/2014 03:51 PM, Alexander Graf wrote: > > On 07.07.14 09:08, Eric Auger wrote: >> Allows sysbus devices to be instantiated from command line by >> using -device option >> >> --- >> >> Inspired from what Alex Graf did in ppc e500 >> https://lists.gnu.org/archive/html/qemu-ppc/2014-07/msg00012.html >> >> Signed-off-by: Alexander Graf <agraf@xxxxxxx> >> Signed-off-by: Eric Auger <eric.auger@xxxxxxxxxx> >> --- >> hw/arm/virt.c | 58 >> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++- >> 1 file changed, 57 insertions(+), 1 deletion(-) >> >> diff --git a/hw/arm/virt.c b/hw/arm/virt.c >> index eeecdbf..3a21db4 100644 >> --- a/hw/arm/virt.c >> +++ b/hw/arm/virt.c >> @@ -40,6 +40,8 @@ >> #include "exec/address-spaces.h" >> #include "qemu/bitops.h" >> #include "qemu/error-report.h" >> +#include "hw/misc/platform_devices.h" >> +#include "hw/vfio/vfio-platform.h" >> #define NUM_VIRTIO_TRANSPORTS 32 >> @@ -57,6 +59,14 @@ >> #define GIC_FDT_IRQ_PPI_CPU_START 8 >> #define GIC_FDT_IRQ_PPI_CPU_WIDTH 8 >> +#define MACHVIRT_PLATFORM_BASE 0xa004000 > > That's an odd address for a 128MB window. Can you make it 128MB aligned? > Maybe move the virtio region behind this one? Yes you're right. I didn't pay attention to that. Now we have to find a hole agreed with everybody if that's feasible ;-) > > With a bit of smartness we don't need a virtio-mmio region with this > patch set anymore btw. We could just generate the virtio-mmio devices on > our platform bus on the fly. > >> +#define MACHVIRT_PLATFORM_HOLE (128ULL * 1024 * 1024) /* 128 >> MB */ > > As Scott mentioned in the e500 review round, "hole" is an odd name ;). OK I will rename that. > > > Alex > _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
