On 2014/6/30 20:39, Marc Zyngier wrote:
Hi Li,
On 30/06/14 12:10, john.liuli wrote:
From: Li Liu <john.liuli@xxxxxxxxxx>
HSCTLR.EE is defined as bit[25] referring to arm manual
DDI0606C.b(p1590).
Signed-off-by: Li Liu <john.liuli@xxxxxxxxxx>
---
arch/arm/kernel/hyp-stub.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/kernel/hyp-stub.S b/arch/arm/kernel/hyp-stub.S
index 797b1a6..7955578 100644
--- a/arch/arm/kernel/hyp-stub.S
+++ b/arch/arm/kernel/hyp-stub.S
@@ -135,7 +135,7 @@ ENTRY(__hyp_stub_install_secondary)
THUMB( orr r7, #(1 << 30) ) @ HSCTLR.TE
#ifdef CONFIG_CPU_BIG_ENDIAN
- orr r7, #(1 << 9) @ HSCTLR.EE
+ orr r7, #(1 << 25) @ HSCTLR.EE
#endif
mcr p15, 4, r7, c1, c0, 0 @ HSCTLR
Thanks for writing this patch. A few things:
- Please use the canonical syntax for orr (orr r7, r7, #(1 << 25))
- Use the ARM_BE8 macro instead of the open-coded CONFIG_CPU_BIG_ENDIAN
- Most importantly, please CC the linux-arm-kernel mailing list
Thanks for your patience and guidance and I will prepare v2 immediately.
Li.
Thanks,
M.
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
