On 06/26/2014 12:28 AM, Alexander Graf wrote: > > On 26.06.14 00:28, Peter Maydell wrote: >> On 2 June 2014 08:49, Eric Auger <eric.auger@xxxxxxxxxx> wrote: >>> This patch aims at allowing the end-user to specify the device he >>> wants to directly assign to his mach-virt guest in the QEMU command >>> line. >>> hw/arm/virt.c | 222 >>> +++++++++++++++++++++++++++++++++++++++++--------- >> This is way too much code to be adding to virt.c. I really don't >> want to be dealing with VFIO related code in board models >> beyond an absolute minimal "go do vfio stuff if the user asked >> for it" set of hooks. Hi Alex, Peter, Thanks for your comments. I am currently preparing v4 where I use the same technique as Alex did in [PATCH 4/5] PPC: e500: Support platform devices (http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00847.html), ie. using - qemu_add_machine_init_done_notifier - qemu_register_reset, which seems to be the right clean way to do what I tried to achieve here. Alex, actually I am reusing the code you put in e500, moved it in a separate helper file. That way, effectively, I will be able to have very few vfio specific code in the machine file. Best Regards Eric > > And device tree chunks :). > > > Alex > _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
