Re: [PATCH v4 00/19] kvm-unit-tests/arm: initial drop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 10, 2014 at 06:56:41PM +0200, Andrew Jones wrote:
> This is a v4 of a series that introduces arm to kvm-unit-tests. First,
> it does some tidying up of the repo. Then, it adds support for device
> trees (libfdt), and for virtio-testdev[1]. Next, it adds the basic
> infrastructure for booting a test case (guest), and adds a first
> test case, a self-test to confirm setup was completed successfully.
> Finally, it further prepares the framework for more complicated tests
> by adding vector support, and extends the self-test to test that too.
> 
> This initial drop doesn't require kvmarm. qemu-system-arm is enough,
> but it must have mach-virt, and the virtio-testdev patch[1].
> 

This is overall looking really good!

I only had a few comments and questions, but you should be able to sort
that out quickly.

It's a lot of code and growing for every iteration, and this time it was
a long gap since the last review, so it took me a while.

I think it would be great if you can address my comments quickly and we
can this merged without futher churn and let new functionality come as
separate extra patches afterwards.

Thanks,
-Christoffer
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm




[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux