BUG_ON in access_vm_reg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marc, Christoffer,

While working on BE patches the following observation occurred
to me. In the same vein as Marc caught my mistake with BUG_ON
in [1] does the code have similar issue in access_vm_reg function?
In this function we have:

    BUG_ON(!p->is_write);

My reading of this: if guest will issue read instruction for those
registers before HCR_TVM is cleared it will crash host kernel. Is
it right? I think guest should not crash host kvm kernel in similar
way as userspace KVM ioctl should not crash kernel. Or am I
missing something here?

V7 version of access_vm_reg has the same issue.

Thanks,
Victor

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-May/256069.html
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm




[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux