On 25 April 2014 20:24, Rob Herring <robherring2@xxxxxxxxx> wrote: > I don't see the point of MISMATCH_CHECK with 0.2 PSCI. The values are > fixed and the header is the ABI. Why can't all of QEMU use the psci.h > header? That would depend on where the psci.h header comes from. In general we can't use kernel headers because the kernel doesn't guarantee that they'll compile on all the platforms QEMU needs to build on. Beyond that, we have a build system problem with trying to use them on non-Linux systems -- we can't put the linux-headers/ directories on the include path because of all the other nonportable headers, but if we take a copy of psci.h into QEMU's include tree then its defines will clash with the ones in the linux-headers/ copy if we are building on Linux with KVM. Putting the defines in a separate definitely-won't-clash namespace and doing a compile time check that we have the same values was my pragmatic solution to the general problem. thanks -- PMM _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
