Re: [Qemu-devel] [PATCH v6 19/37] target-arm: Implement AArch64 EL1 exception handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14 April 2014 07:04, Peter Crosthwaite <peter.crosthwaite@xxxxxxxxxx> wrote:
> On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell <peter.maydell@xxxxxxxxxx> wrote:
>> From: Rob Herring <rob.herring@xxxxxxxxxx>
>> +    switch (cs->exception_index) {
>> +    case EXCP_PREFETCH_ABORT:
>> +    case EXCP_DATA_ABORT:
>> +        qemu_log_mask(CPU_LOG_INT, "...with FAR 0x%" PRIx64 "\n",
>> +                      env->cp15.far_el1);
>
> need a /* fallthrough */

I think a simple 'break;' would be better, actually.

> otherwise:
>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xxxxxxxxxx>

thanks
-- PMM
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm




[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux