On Fri, Mar 7, 2014 at 5:33 AM, Peter Maydell <peter.maydell@xxxxxxxxxx> wrote: > Support the Cortex-A57 in the virt machine model. > > Signed-off-by: Peter Maydell <peter.maydell@xxxxxxxxxx> > --- > This should perhaps not be just stealing the a15mpcore_priv > on the basis that it's a GICv2... Wont this mean you gets lots of extraneous hardware? Although, with a pure virtual machine I guess you can do whatever you really want. > --- > hw/arm/virt.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 517f2fe..d985d2e 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -123,6 +123,14 @@ static VirtBoardInfo machines[] = { > .irqmap = a15irqmap, > }, > { > + .cpu_model = "cortex-a57", > + /* Use the A15 private peripheral model for now: probably wrong! */ > + .qdevname = "a15mpcore_priv", Can you just change this to gics qdev name? The qdev propnames of gic and mpcore ("num-cpu" and "num-irq") should just match. Then perhaps a little callback to set gicv2 version property. Regards, Peter > + .gic_compatible = "arm,cortex-a15-gic", > + .memmap = a15memmap, > + .irqmap = a15irqmap, > + }, > + { > .cpu_model = "host", > /* We use the A15 private peripheral model to get a V2 GIC */ > .qdevname = "a15mpcore_priv", > -- > 1.9.0 > > _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm