|
Marc,
On 06/03/2014 04:30, Marc Zyngier wrote:
Paolo, Michele,
On 2014-03-04 15:31, Paolo Bonzini wrote:
Il 04/03/2014 16:10, Michele Paolino ha
scritto:
When the kernel is configured without
CONFIG_KVM_ARM_VGIC, the
compilation process fails with :
arch/arm/kvm/arm.c: In function
'kvm_vm_ioctl_set_device_addr':
arch/arm/kvm/arm.c:797:3: error: implicit declaration of
function 'kvm_vgic_addr'
[-Werror=implicit-function-declaration]
return kvm_vgic_addr(kvm, type, &dev_addr->addr,
true)
Signed-off-by: Michele Paolino
<m.paolino@xxxxxxxxxxxxxxxxxxxxxx>
---
include/kvm/arm_vgic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h
index be85127..0bab057 100644
--- a/include/kvm/arm_vgic.h
+++ b/include/kvm/arm_vgic.h
@@ -143,8 +143,8 @@ struct kvm_vcpu;
struct kvm_run;
struct kvm_exit_mmio;
-#ifdef CONFIG_KVM_ARM_VGIC
int kvm_vgic_addr(struct kvm *kvm, unsigned long type, u64
*addr, bool write);
+#ifdef CONFIG_KVM_ARM_VGIC
int kvm_vgic_hyp_init(void);
int kvm_vgic_init(struct kvm *kvm);
int kvm_vgic_create(struct kvm *kvm);
Christoffer, Marc, I can queue this directly for kvm/master if
it's okay
for you.
This patch looks a bit wrong. Why would we need to configure the
vgic addresses if the vgic is explicitly disabled?
Furthermore, I doubt it leads to a kernel that actually links, as
the file containing kvm_vgic_addr will not be compiled...
what I've proposed links but your solution is better ;-)
Instead, please consider applying the attached patch
(quickly tested on a Cubietruck).
Tested, it's OK.
Thanks,
Thanks,
M.
--
Michele Paolino,
Virtualization R&D Engineer
Virtual Open Systems
Open Source KVM
Virtualization Developments
Multicore Systems Virtualization
Porting Services
Web: www.virtualopensystems.com
|
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
