Re: [RFC PATCH 2/7] target-arm: Try X-Gene Potenza target type for KVM Aarch64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27 February 2014 15:19, Peter Maydell <peter.maydell@xxxxxxxxxx> wrote:
> On 27 February 2014 06:51, Pranavkumar Sawargaonkar
> <pranavkumar@xxxxxxxxxx> wrote:
>> QEMU Aarch64 tries various target types in kvm_arm_get_host_cpu_features()
>> to determine perferred VCPU target type and VCPU features.
>>
>> This patch adds target type KVM_ARM_TARGET_XGENE_POTENZA to cpus_to_try[]
>> of kvm_arm_get_host_cpu_features().
>>
>> Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@xxxxxxxxxx>
>> Signed-off-by: Anup Patel <anup.patel@xxxxxxxxxx>
>> ---
>>  target-arm/kvm64.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/target-arm/kvm64.c b/target-arm/kvm64.c
>> index 1b7ca90..406529f 100644
>> --- a/target-arm/kvm64.c
>> +++ b/target-arm/kvm64.c
>> @@ -48,6 +48,7 @@ bool kvm_arm_get_host_cpu_features(ARMHostCPUClass *ahcc)
>>          KVM_ARM_TARGET_AEM_V8,
>>          KVM_ARM_TARGET_FOUNDATION_V8,
>>          KVM_ARM_TARGET_CORTEX_A57,
>> +        KVM_ARM_TARGET_XGENE_POTENZA,
>>          QEMU_KVM_ARM_TARGET_NONE
>>      };
>>      struct kvm_vcpu_init init;
>
> No, this is wrong. Read the comment above this array, which
> explains why. We should never add any more entries to this array.


Ok I will drop this patch.
(Resending by correcting qemu-devel mail id, my mistake in sending the
1st patch)

>
> thanks
> -- PMM

Thanks,
Pranav
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm




[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux