On Fri, Feb 14, 2014 at 11:00:31PM +0000, Stuart Yoder wrote: > > > > -----Original Message----- > > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > > Sent: Friday, February 14, 2014 4:27 PM > > To: Antonios Motakis > > Cc: alex.williamson@xxxxxxxxxx; kvmarm@xxxxxxxxxxxxxxxxxxxxx; > > iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > > tech@xxxxxxxxxxxxxxxxxxxxxx; a.rigo@xxxxxxxxxxxxxxxxxxxxxx; Yoder Stuart- > > B08248; kim.phillips@xxxxxxxxxx; jan.kiszka@xxxxxxxxxxx; > > kvm@xxxxxxxxxxxxxxx; Bhushan Bharat-R65777; Wood Scott-B07421; > > christoffer.dall@xxxxxxxxxx; agraf@xxxxxxx; Sethi Varun-B16395; > > will.deacon@xxxxxxx; Tejun Heo; Rafael J. Wysocki; Guenter Roeck; Toshi > > Kani; Joe Perches; Dmitry Kasatkin; Michal Hocko; Bjorn Helgaas > > Subject: Re: [RFC PATCH v4 01/10] driver core: export > > driver_probe_device() > > > > On Sat, Feb 08, 2014 at 06:29:31PM +0100, Antonios Motakis wrote: > > > From: Kim Phillips <kim.phillips@xxxxxxxxxx> > > > > > > Needed by drivers, such as the vfio platform driver [1], seeking to > > > bypass bind_store()'s driver_match_device(), and bind to any device > > > via a private sysfs bind file. > > > > > > [1] https://lkml.org/lkml/2013/12/11/522 > > > > > > note: the EXPORT_SYMBOL is needed because vfio-platform can be built > > > as a module. > > > > No code outside of drivers/base/ should be calling this function > > Why? driver_probe_device() allows a driver to explicitly bind > to a specific device. What is conceptually wrong with allowing > that? Because that's not how a bus should work, and the fact that no other subsystem in the kernel does that might be a hint you are trying to do something a bit "wrong" here. greg k-h _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
