On 01/10/2014 09:12 AM, Peter Maydell wrote: > + case 0: /* Replicate(Zeros(24):imm8, 2) */ > + case 1: /* Replicate(Zeros(16):imm8:Zeros(8), 2) */ > + case 2: /* Replicate(Zeros(8):imm8:Zeros(16), 2) */ > + case 3: /* Replicate(imm8:Zeros(24), 2) */ > + { > + int shift = cmode_3_1 * 8; > + imm = (abcdefgh << shift) | (abcdefgh << (32 + shift)); > + break; > + } Better to use bitfield_replicate with these? Reviewed-by: Richard Henderson <rth@xxxxxxxxxxx> r~ _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm