On Sat, Dec 28, 2013 at 10:31:44PM -0800, Christoffer Dall wrote:
> > +
> > + if (npad < 0) {
> > + char pad = props.pad;
> > + if (pad == '0') /* ignore '0' flag with '-' flag */
> > + pad = ' ';
>
> there are only the two options, so you can drop the check if
> you like.
true. removed.
> > +static int fmtnum(const char **fmt)
> > +{
> > + const char *f = *fmt;
> > + int len = 0, num;
> > +
> > + if (*f == '-')
> > + ++f, ++len;
>
> oh wow, this deserves a small comment saying that negative values are
> used to add trailing padding instead of leading.
You mean something beyond "man 3 printf; /flag"? :-)
>
> > +
> > + while (*f >= '0' && *f <= '9')
> > + ++f, ++len;
> > +
> > + num = atol(*fmt);
> > + *fmt += len;
> > + return num;
> > }
>
> some funny indentation is back here... Better check your entire patch
> for that.
The whole file has the funny indentation, I just followed suit. The
alternative is to add a patch that "fixes" all the pre-existing lib/*
files first, but for this patch I didn't think it was worth it.
drew
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
