Re: [PATCH 02/22] softfloat: Add float to 16bit integer conversions.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31 December 2013 14:18, Richard Henderson <rth@xxxxxxxxxxx> wrote:
> On 12/31/2013 05:35 AM, Peter Maydell wrote:
>> +    int64_t v;
>> +    int_fast16_t res;
>> +    int old_exc_flags = get_float_exception_flags(status);
>> +
>> +    v = float32_to_int64(a STATUS_VAR);
>
> Any good reason not to use int32 as the intermediate, for the benefit of 32-bit
> hosts?

You mean 'v'? Making v less than 64 bits will give wrong results
for input values which fit in a 64 bit int but not a 32 bit int, won't it?
Or do you mean we should call float32_to_int32() instead?
I think that ought to work...

thanks
-- PMM
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm




[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux