On 19 December 2013 19:29, Richard Henderson <rth@xxxxxxxxxxx> wrote: > On 12/17/2013 07:12 AM, Peter Maydell wrote: >> + tcg_gen_mul_i64(tcg_tmp, tcg_op1, tcg_op2); >> + if (is_sub) { >> + tcg_gen_sub_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp); >> + } else { >> + tcg_gen_add_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp); >> + } > > Perhaps worth noticing the RA=XZR special case for the MUL alias? Yeah, makes sense: have adjusted to: + if (ra == 31) { + /* We special-case rA == XZR as it is the standard MUL alias */ + tcg_gen_mul_i64(cpu_reg(s, rd), tcg_op1, tcg_op2); + } else { + tcg_gen_mul_i64(tcg_tmp, tcg_op1, tcg_op2); + if (is_sub) { + tcg_gen_sub_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp); + } else { + tcg_gen_add_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp); + } + } thanks -- PMM _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm