On 12/06/2013 10:51 AM, Peter Maydell wrote: > + switch (opcode) { > + case 2: /* UDIV */ > + handle_div(s, FALSE, sf, rm, rn, rd); > + break; > + case 3: /* SDIV */ > + handle_div(s, TRUE, sf, rm, rn, rd); > + break; What are these all-caps TRUE/FALSE? stdbool.h uses lower-case. Otherwise, Reviewed-by: Richard Henderson <rth@xxxxxxxxxxx> r~ _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm