On 12/06/2013 11:31 AM, Peter Maydell wrote:
> On 5 December 2013 22:26, Richard Henderson <rth@xxxxxxxxxxx> wrote:
>> On 12/06/2013 10:51 AM, Peter Maydell wrote:
>>> + if (cond >= 0x0e) { /* condition "always" */
>>> + tcg_src = read_cpu_reg(s, rn, sf);
>>> + tcg_gen_mov_i64(tcg_rd, tcg_src);
>>
>> I wonder if it's worth adding that 0x0[ef] case to the generic condition
>> processing rather than keep replicating it everywhere.
>>
>>> + } else {
>>> + /* OPTME: we could use movcond here, at the cost of duplicating
>>> + * a lot of the arm_gen_test_cc() logic.
>>> + */
>>
>> Honestly, arm_gen_test_cc should get refactored to a real test (as opposed to
>> branch) sooner rather than later.
>
> By "sooner rather than later" do you mean "as part of this patch series" ?
It might make later patch series easier. But I won't insist.
r~
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
