On 4 December 2013 00:03, Richard Henderson <rth@xxxxxxxxxxx> wrote:
> On 12/04/2013 10:51 AM, Peter Maydell wrote:
>> + if (cond < 0x0e) {
>> + /* genuinely conditional branches */
>> + int label_nomatch = gen_new_label();
>> + arm_gen_test_cc(cond ^ 1, label_nomatch);
>> + gen_goto_tb(s, 0, addr);
>> + gen_set_label(label_nomatch);
>> + gen_goto_tb(s, 1, s->pc);
>
> Why swap the condition with "^ 1"? You can just as easily swap the goto_tb. I
> realize the A32 translator does it this way, but need we continue?
Good point; will change.
thanks
-- PMM
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
