Re: [PATCH] arm/arm64: KVM: Fix hyp mappings of vmalloc regions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday 16 November 2013 12:15 PM, Christoffer Dall wrote:
> On Sat, Nov 16, 2013 at 10:01:01AM +0000, Marc Zyngier wrote:
>> On 2013-11-15 23:24, Christoffer Dall wrote:
>>> Using virt_to_phys on percpu mappings is horribly wrong as it may be
>>> backed by vmalloc.  Introduce kvm_kaddr_to_phys which translates both
>>> types of valid kernel addresses to the corresponding physical
>>> address.
>>>
>>> At the same time resolves a typing issue where we were storing the
>>> physical address as a 32 bit unsigned long (on arm), truncating the
>>> physical address for addresses above the 4GB limit.  This caused
>>> breakage on Keystone.
>>>
>>> Reported-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
>>> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>
>>> Signed-off-by: Christoffer Dall <christoffer.dall@xxxxxxxxxx>
>>> ---
>>>
>>> This patch is loosely based on Marc's previous patch from today but
>>> instead of introducing another Hyp mapping function, it fixes the
>>> existing one to deal with both kinds of kernel addresses.
>>
>> Looks good to me! This should probably be merged quickly (after
>> testing by Santosh), and possibly Cc-ed to stable.
>>
> Agreed, Santhos, can you give this a quick spin?
> 
Works as expected.

Regards,
Santosh

_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm




[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux