On 26/09/13 17:17, Christoffer Dall wrote: > On Thu, Sep 26, 2013 at 04:49:28PM +0100, Jonathan Austin wrote: >> This patch adds support for running Cortex-A7 guests on Cortex-A7 hosts. >> >> As Cortex-A7 is architecturally compatible with A15, this patch is largely just >> generalising existing code. Areas where 'implementation defined' behaviour >> is identical for A7 and A15 is moved to allow it to be used by both cores. >> >> The check to ensure that coprocessor register tables are sorted correctly is >> also moved in to 'common' code to avoid each new cpu doing its own check >> (and possibly forgetting to do so!) >> >> Signed-off-by: Jonathan Austin <jonathan.austin@xxxxxxx> >> Acked-by: Marc Zyngier <marc.zyngier@xxxxxxx> > > The patch itself looks good, I'm wondering if we are creating potential > confusion by not having a separate table for shared, but implementation > defined, co-processors. One option would be to have multiple levels of > 'inheritance' of the the coprocessor table, so you could load the > generic one, overload it with the a15 one, and then overload it with the > a7 one. That may be a bit over-engineerd though. > > Then again, if A7/A15 end up being just two cores out of many many more, > it's a bit weird to have their register definitions in the coproc.c > files and everyone elses in their own files, sort of pushing the problem > under the rug. > > Unless of course we just agree that there are probably not going to be > that many cores and they're all just going to look a lot like each other > wrt. to the impdef registers anyhow, so it makes sense to provide this > default implementation... Certainly for now it looks this way to me... As Marc says, A12 should look a lot like the other cores here. > > If nobody else objects, I'm ok with merging this code (once I have a > chance to test it). We can always add more logic and move things around > later, as there's no api breakage or anything like that. Cool - give me a shout if you need any help with the TC2 setup for testing, etc. I used boot-wrapper/mon.axf for hyp booting as you'd expect, and board.txt to hold the A15s in reset and select A7s as the boot cluster. Jonny > > Thanks for taking care of this! > > -Christoffer > _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
