On 25 July 2013 23:34, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote: > On Thu, Jul 25, 2013 at 02:37:43PM +0100, Peter Maydell wrote: >> case VIRTIO_MMIO_QUEUENUMMAX: >> + if (virtio_queue_get_num(vdev, vdev->queue_sel) == 0) { >> + return 0; >> + } > > All other callers do: > if (!virtio_queue_get_num(vdev, vdev->queue_sel)) { > > So please make this one consistent and use the shorter form. OK. -- PMM _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm