> -----Original Message----- > From: iommu-bounces@xxxxxxxxxxxxxxxxxxxxxxxxxx [mailto:iommu- > bounces@xxxxxxxxxxxxxxxxxxxxxxxxxx] On Behalf Of Antonios Motakis > Sent: Tuesday, July 23, 2013 3:32 PM > To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; iommu@lists.linux- > foundation.org; linux-samsung-soc@xxxxxxxxxxxxxxx > Cc: Sachin Kamat; Jiri Kosina; open list; Wei Yongjun; Antonios Motakis; > Cho KyongHo; kvmarm@xxxxxxxxxxxxxxxxxxxxx > Subject: [PATCH] iommu/exynos: add devices attached to the System MMU to > an IOMMU group > > IOMMU groups are expected by certain users of the IOMMU API, e.g. VFIO. > Since each device is behind its own System MMU, we can allocate a new > IOMMU group for each device. > > This patch depends on Cho KyongHo's patch series titled "[PATCH v7 00/12] > iommu/exynos: Fixes and Enhancements of System MMU driver with DT", > applied on a Linux 3.10.1 kernel. It has been tested on the Arndale > board. > > Signed-off-by: Antonios Motakis <a.motakis@xxxxxxxxxxxxxxxxxxxxxx> > --- > drivers/iommu/exynos-iommu.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index 51d43bb..9f39eaa 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -1134,6 +1134,28 @@ static phys_addr_t > exynos_iommu_iova_to_phys(struct iommu_domain *domain, > return phys; > } > > +static int exynos_iommu_add_device(struct device *dev) { > + struct iommu_group *group; > + int ret; > + > + group = iommu_group_alloc(); > + if (IS_ERR(group)) { > + dev_err(dev, "Failed to allocate IOMMU group\n"); > + return PTR_ERR(group); > + } > + > + ret = iommu_group_add_device(group, dev); > + iommu_group_put(group); > + > + return ret; > +} > + > +static void exynos_iommu_remove_device(struct device *dev) { > + iommu_group_remove_device(dev); > +} > + > static struct iommu_ops exynos_iommu_ops = { > .domain_init = &exynos_iommu_domain_init, > .domain_destroy = &exynos_iommu_domain_destroy, @@ -1142,6 +1164,8 > @@ static struct iommu_ops exynos_iommu_ops = { > .map = &exynos_iommu_map, > .unmap = &exynos_iommu_unmap, > .iova_to_phys = &exynos_iommu_iova_to_phys, > + .add_device = exynos_iommu_add_device, > + .remove_device = exynos_iommu_remove_device, > .pgsize_bitmap = SECT_SIZE | LPAGE_SIZE | SPAGE_SIZE, }; > [Sethi Varun-B16395] Do you support PCI devices? This assumption of one iommu group per pci device may not hold true in case of PCI devices. -Varun _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
