On 18/04/13 19:38, Christoffer Dall wrote: > On Thu, Apr 18, 2013 at 7:40 AM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote: >> On 18/04/13 15:16, Giridhar Maruthy wrote: >> >> Hi Giridhar, >> >>> Thanks a lot for pointing me at the series. >>> I did apply the series and got cpu hotplug to work successfully. >> >> Ah, good to know. Thanks for testing. >> >>> However, I have the following doubts. >>> >>> 1. Though the guest does not crash, when exiting the qemu, I get the >>> following crash dump. I have not yet looked into the details. >>> > > I haven't been able to reproduce this. Can you tell us the exact steps > you take to reproduce? > >>> >>> [ 547.870000] [<c00145b0>] (unmap_range+0x9c/0x2f4) from [<c0014c2c>] >>> (kvm_free_stage2_pgd+0x30/0x4c) >>> [ 547.880000] [<c0014c2c>] (kvm_free_stage2_pgd+0x30/0x4c) from >>> [<c00129c8>] (kvm_arch_destroy_vm+0xc/0x38) >>> [ 547.890000] [<c00129c8>] (kvm_arch_destroy_vm+0xc/0x38) from >>> [<c000eb6c>] (kvm_put_kvm+0xec/0x150) >>> [ 547.900000] [<c000eb6c>] (kvm_put_kvm+0xec/0x150) from [<c000f068>] >>> (kvm_vcpu_release+0x10/0x18) >>> [ 547.910000] [<c000f068>] (kvm_vcpu_release+0x10/0x18) from >>> [<c00bebcc>] (__fput+0x88/0x1dc) >>> [ 547.920000] [<c00bebcc>] (__fput+0x88/0x1dc) from [<c0044810>] >>> (task_work_run+0xac/0xe8) >>> [ 547.920000] [<c0044810>] (task_work_run+0xac/0xe8) from [<c0030cb8>] >>> (do_exit+0x22c/0x82c) >>> [ 547.930000] [<c0030cb8>] (do_exit+0x22c/0x82c) from [<c003132c>] >>> (do_group_exit+0x48/0xb0) >>> [ 547.940000] [<c003132c>] (do_group_exit+0x48/0xb0) from [<c003b618>] >>> (get_signal_to_deliver+0x278/0x504) >>> [ 547.950000] [<c003b618>] (get_signal_to_deliver+0x278/0x504) from >>> [<c001c8e4>] (do_signal+0x74/0x460) >>> [ 547.960000] [<c001c8e4>] (do_signal+0x74/0x460) from [<c001d150>] >>> (do_work_pending+0x64/0xac) >>> [ 547.970000] [<c001d150>] (do_work_pending+0x64/0xac) from >>> [<c00199c0>] (work_pending+0xc/0x20) >>> [ 547.980000] Code: e1927003 0afffff0 e7e80658 e3a0c000 (e1cc20d0) >>> [ 547.980000] ---[ end trace 05d3020cd57fa289 ]--- >>> [ 547.990000] Fixing recursive fault but reboot is needed! >> >> It probably means we're having issues with the Stage-2 page refcounts. >> Can you share the whole dump (I think there's a few additional lines >> before what you quoted)? >> >>> 2. I applied kvm-arm-fixes branch from Christoffer's tree >>> (github.com/virtualopensystems/linux-kvm-arm >>> <http://github.com/virtualopensystems/linux-kvm-arm>) and then applied >>> the v4 series of "ARM: KVM: Revamping the HYP init code for fun and >>> profit". I ran into some merge conflicts. So I manually edited and >>> applied the patches. Should I be including any more dependant patches? >> >> You'd be better of using the following branch: >> git://github.com/columbia/linux-kvm-arm.git kvm-arm-for-next >> >> as it should contain all you need. I haven't tested it yet, though. >> > > so I just tried this on vexpress TC2, and when I hotplug cpu1, I get > the crash below. Is this actually supposed to work at this point?: If someone writes the enter-HYP-from-hotplug code, it will work. So far, I didn't have any bandwidth for that yet, and I think this should be provided by the bootloader somehow, if not by the firmware. M. -- Jazz is not dead. It just smells funny... _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
