Re: [PATCH] KVM: ARM: Fix wrong address in comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 18, 2013 at 10:19 PM, Jonghwan Choi <jhbird.choi@xxxxxxxxxxx> wrote:
> hyp_hvc vector offset is 0x14 and hyp_svc vector offset is 0x8.
>

indeed, thanks for spotting it.

> Signed-off-by: Jonghwan Choi <jhbird.choi@xxxxxxxxxxx>
> ---
>  arch/arm/kvm/interrupts.S |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/kvm/interrupts.S b/arch/arm/kvm/interrupts.S
> index c33a0f5..e3a5721 100644
> --- a/arch/arm/kvm/interrupts.S
> +++ b/arch/arm/kvm/interrupts.S
> @@ -237,9 +237,9 @@ ENTRY(kvm_call_hyp)
>   * instruction is issued since all traps are disabled when running the host
>   * kernel as per the Hyp-mode initialization at boot time.
>   *
> - * HVC instructions cause a trap to the vector page + offset 0x18 (see
> hyp_hvc
> + * HVC instructions cause a trap to the vector page + offset 0x14 (see
> hyp_hvc
>   * below) when the HVC instruction is called from SVC mode (i.e. a guest or
> the
> - * host kernel) and they cause a trap to the vector page + offset 0xc when
> HVC
> + * host kernel) and they cause a trap to the vector page + offset 0x8 when
> HVC
>   * instructions are called from within Hyp-mode.
>   *
>   * Hyp-ABI: Calling HYP-mode functions from host (in SVC mode):
> --
> 1.7.4.1
>
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux