[PATCH 01/16] KVM: ARM: vgic: Add comment for SGI handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Christoffer Dall <c.dall@xxxxxxxxxxxxxxxxxxxxxx>

The !sources case can be quite confusing, help the reader.

Signed-off-by: Christoffer Dall <c.dall@xxxxxxxxxxxxxxxxxxxxxx>
---
 arch/arm/kvm/vgic.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/kvm/vgic.c b/arch/arm/kvm/vgic.c
index 4885e13..6f26c27 100644
--- a/arch/arm/kvm/vgic.c
+++ b/arch/arm/kvm/vgic.c
@@ -893,6 +893,12 @@ static void __kvm_vgic_sync_to_cpu(struct kvm_vcpu *vcpu)
 			clear_bit(c, &sources);
 		}
 
+		/*
+		 * If the sources bitmap has been cleared it means that we
+		 * could queue all the SGIs onto link registers (see the
+		 * clear_bit above), and therefore we are done with them in
+		 * our emulated gic and can get rid of them.
+		 */
 		if (!sources) {
 			vgic_dist_irq_clear(vcpu, i);
 			vgic_cpu_irq_clear(vcpu, i);
-- 
1.8.0.1



_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux