Re: [PATCH] bootwrapper: Fix check for architected timer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30 November 2012 15:30, Jon Medhurst (Tixy) <tixy@xxxxxxxxxx> wrote:
> From: Will Deacon <will.deacon@xxxxxxx>
>
> We need to set the flags when checking the feature register.
>
> Signed-off-by: Will Deacon <will.deacon@xxxxxxx>
> ---
>
> I found this patch in another fork of the bootwrapper and it looks like
> something we should have. On the A15 and big.LITTLE setups I've tested
> it makes no difference so I guess the z flag was already clear or the
> architected timers are already running at 24MHz.
>
>  boot.S |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/boot.S b/boot.S
> index 40ebd33..dd453e3 100644
> --- a/boot.S
> +++ b/boot.S
> @@ -78,7 +78,7 @@ start:
>         @
>         mrc     p15, 0, r0, c0, c1, 1           @ CPUID_EXT_PFR1
>         lsr     r0, r0, #16
> -       and     r0, r0, #1                      @ Check generic timer support
> +       ands    r0, r0, #1                      @ Check generic timer support
>         beq     1f
>         ldr     r0, =24000000                   @ 24MHz timer frequency
>         mcr     p15, 0, r0, c14, c0, 0          @ CNTFRQ
> --

Er, this patch doesn't apply at all to the kvm bootwrapper.
Is there some other patch it depends on that we should have?

thanks
-- PMM
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux