Re: [RFC PATCH] KVM: ARM: Avodid compiler warning and bugfix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 3, 2012 at 3:06 PM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote:
> On 03/12/12 19:47, Christoffer Dall wrote:
>> On Mon, Dec 3, 2012 at 2:28 PM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote:
>>> On 03/12/12 19:22, Christoffer Dall wrote:
>>>> On Mon, Dec 3, 2012 at 2:19 PM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote:
>>>>> On 03/12/12 19:07, Christoffer Dall wrote:
>>>>>> Some compilers complain about unaligned opcodes with the strings
>>>>>> embedded in the text section.  Therefore move the panic strings to
>>>>>> the rodata section to avoid the compile error.
>>>>>
>>>>> How old is this compiler?
>>>>>
>>>> arm-linux-gnueabi-gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
>>>> Copyright (C) 2011 Free Software Foundation, Inc.
>>>> This is free software; see the source for copying conditions.  There is NO
>>>> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>>>
>>> Irk. Quite recent. Oh well...
>>>
>>>         M.
>>> --
>>> Jazz is not dead. It just smells funny...
>>>
>>
>> ok, to the patch then?
>
> If this is the only solution, then I guess so. You try leaving the
> strings where they are and have a .pushsection/.popsection instead.
>
I did not - is this preferred?

I noticed the section(".rodata") was used in other assembler files for
this purpose...
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux