Re: [PATCH] kvm-tool: ARM: set interrupt priority mask in secondary boot path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29 November 2012 15:58, Marc Zyngier <marc.zyngier@xxxxxxx> wrote:
> A bug in the KVM GIC init code set the priority mask to the
> highest possible value, while the reset value should be zero.
>
> Now that the kernel bug is fixed, kvm-tool must properly configure
> its GIC CPU interface in order to receive the boot IPI.  Just set
> the GICC_PMR register to the maximum value (0xff), and it "just works".

> --- a/tools/kvm/arm/include/arm-common/gic.h
> +++ b/tools/kvm/arm/include/arm-common/gic.h
> @@ -20,6 +20,8 @@
>
>  #define GIC_CPUI_CTLR_EN               (1 << 0)
>
> +#define GIC_CPUI_DEFAULT_PMR           0xff

This seems an odd name, since 0xff is not the default, which is
why we have to write it into the register. Also the register
name should presumably go after CPUI, to match CTLR above.
GIC_CPUI_PMR_MINIMUM_PRIORITY ?

-- PMM
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux