Re: [PATCH] KVM: ARM: Don't use set_pte_ext (a.k.a. Fix the voodoo bug!)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 23, 2012 at 5:05 AM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote:
> On 23/11/12 00:59, Christoffer Dall wrote:
>> From: Christoffer Dall <cdall@xxxxxxxxxxxxxxx>
>>
>> The set_pte_ext function orr'ed the RDONLY bit onto the PTEs, which is
>> bit[7], which is HAP[1] and causes writable access to the pages.
>
> So let me rephrase this to see if I got it correctly:
> - set_pte_ext checks that L_PTE_DIRTY is set
> - If not, it sets the L_PTE_RDONLY bit
> - Stage2 doesn't set any software bit, hence L_PTE_DIRTY is always clear
> - L_PTE_RDONLY maps to HAP[2], which controls the write permission.
> - Hence *all* Stage2 mappings are writable.
> - ...
>
> It's only 10am, and I already need a beer...
>
I had one yesterday, which was the reason for my profanity on the
public mailing list - sorry about that.
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux