On Wed, Nov 7, 2012 at 6:11 PM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote:
On 07/11/12 16:04, Anton Romanov wrote:So far, we only have static mappings (we don't expect the hardware to be
> What is the proper way for removing mapping created by
> kvm_phys_addr_ioremap so that the same guest address could be remapped
> to different physical one?
dynamically removed).
To support this, you'll have to carefully remove the mapping from
stage-2 and flush the corresponding TLBs after synchronizing the CPUs.
Patches welcome.
Is the following enough or should I do that differently before submitting patch?
This is how it currently works for me (TLBis invalidated in stage2_clear_pte if needed):
/**
* @brief - unmap a device range from guest IPA
*
* @kvm: The KVM pointer
* @guest_ipa: The IPA at which to insert the mapping
* @size: The size of the mapping
*/
void kvm_phys_addr_unmap(struct kvm *kvm, phys_addr_t guest_ipa,
unsigned long size)
{
phys_addr_t addr, end;
end = (guest_ipa + size + PAGE_SIZE - 1) & PAGE_MASK;
for (addr = guest_ipa; addr < end; addr += PAGE_SIZE) {
spin_lock(&kvm->mmu_lock);
stage2_clear_pte(kvm, addr);
spin_unlock(&kvm->mmu_lock);
}
}
This is how it currently works for me (TLBis invalidated in stage2_clear_pte if needed):
/**
* @brief - unmap a device range from guest IPA
*
* @kvm: The KVM pointer
* @guest_ipa: The IPA at which to insert the mapping
* @size: The size of the mapping
*/
void kvm_phys_addr_unmap(struct kvm *kvm, phys_addr_t guest_ipa,
unsigned long size)
{
phys_addr_t addr, end;
end = (guest_ipa + size + PAGE_SIZE - 1) & PAGE_MASK;
for (addr = guest_ipa; addr < end; addr += PAGE_SIZE) {
spin_lock(&kvm->mmu_lock);
stage2_clear_pte(kvm, addr);
spin_unlock(&kvm->mmu_lock);
}
}
_______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
