Fixing the definition of vgic_initialized() when !CONFIG_KVM_ARM_VGIC is the right way (there's an extra kvm_ there...).
M.
________________________________________
From: kvmarm-bounces@xxxxxxxxxxxxxxxxxxxxx [kvmarm-bounces@xxxxxxxxxxxxxxxxxxxxx] On Behalf Of Christoffer Dall [c.dall@xxxxxxxxxxxxxxxxxxxxxx]
Sent: Saturday, October 27, 2012 8:08 AM
To: haibin wang
Cc: kvmarm@xxxxxxxxxxxxxxxxxxxxx
Subject: Re: A very very small bug--miss #ifdef CONFIG_KVM_ARM_VGIC
On Fri, Oct 26, 2012 at 10:24 AM, haibin wang <wanghaibin202@xxxxxxxxx> wrote:
> There is a very small bug!
>
> branch: kvm_arm_master:
>
> when I don't configure CONFIG_KVM_ARM_VGIC,
> compiling the host kernel will be failure!
>
> In arch/arm/kvm/arm.c file:
> In function kvm_arch_vcpu_ioctl_run:
> Parts of codes should be added "#ifdef CONFIG_KVM_ARM_VGIC" and
> "#endif", as follow:
>
> int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *run)
> {
> ......
>
> #ifdef CONFIG_KVM_ARM_VGIC
> /* Initalize the VGIC before running a vcpu the first time on this VM */
> if (unlikely(irqchip_in_kernel(vcpu->kvm) &&
> !vgic_initialized(vcpu->kvm))) {
> ret = kvm_vgic_init(vcpu->kvm);
> if (ret)
> return ret;
> }
> #endif
>
> ........
> }
thanks for the bug report, I don't think this is the right way to fix
it, but I'll take a look.
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
