On 24/10/2012 18:11, Peter Maydell wrote: > On 23 October 2012 12:55, <fred.konrad@xxxxxxxxxxxxx> wrote: >> Any comment on the patches ? > Just about to embark on a review. Two initial points which > you might want to start in on: > > (1) coding style. scripts/checkpatch.pl can be used to check for > this; note that it sometimes gets confused so you need to apply > some common sense to its output. however it will catch the common > errors like missing braces on if/else, long lines, etc. > > (2) qemu master has just landed a patch which did a global > change of the 'target_phys_addr_t' type to 'hwaddr'. You'll > need to update to match, which will be a mildly tedious but not > too painful process. Ok, thanks Peter, I didn't know about this script and I made the modification. I added change in the transport patch to avoid more than one device per transport and split the patch number 19 because it was unreadable. I update the git ( git://git.greensocs.com/qemu_virtio.git virtio or http://git.greensocs.com/?p=qemu_virtio.git;a=shortlog;h=refs/heads/virtio ) Fred _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
