Re: [PATCH 1/7] ARM: KVM: make sure the VTTBR field can be accessed from asm code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17/10/12 15:25, Anton Romanov wrote:
> I'm not sure about the inkernel coding standards.
> But why can't this be:
> #if KVM_VTTBR > 255
>     add r1, r1, #KVM_VTTBR
>     ldrd    r2, r3, [r1]
> #else
>     ldrd    r2, r3, [r1, #KVM_VTTBR]
> #endif
> ?
> This way you wont add additional cycles if its not needed in particular
> configuration.

As Christoffer said, this is really not worth the hassle. It makes the
code ugly, and the extra fetch+add is going to be lost in the noise anyway.

Better keep it clean, as we're going to maintain this code for a long,
long time...

	M.
-- 
Jazz is not dead. It just smells funny...


_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux