Re: [PATCH 1/7] ARM: KVM: make sure the VTTBR field can be accessed from asm code

[Anton Romanov <theli.ua@xxxxxxxxx>]

Right. I see.

PS. sorry to anyone who i accidentally directly messaged with copies of kernel mails, Gmail reply button betrayed me :(.

On Wed, Oct 17, 2012 at 5:27 PM, Christoffer Dall <c.dall@xxxxxxxxxxxxxxxxxxxxxx> wrote:

On Wed, Oct 17, 2012 at 10:25 AM, Anton Romanov <theli.ua@xxxxxxxxx> wrote:
> I'm not sure about the inkernel coding standards.
> But why can't this be:
> #if KVM_VTTBR > 255
>     add r1, r1, #KVM_VTTBR
>     ldrd    r2, r3, [r1]
> #else
>
>     ldrd    r2, r3, [r1, #KVM_VTTBR]
> #endif
> ?
> This way you wont add additional cycles if its not needed in particular
> configuration.
>

that's way too cluttered for a single cycle imho.

_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm