Re: [RFC PATCH 13/13] hw/vexpress.c : ethernet replaced by virt-mmio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 9, 2012 at 5:24 AM,  <fred.konrad@xxxxxxxxxxxxx> wrote:
> From: KONRAD Frederic <fred.konrad@xxxxxxxxxxxxx>
>
> ---
>  hw/vexpress.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/hw/vexpress.c b/hw/vexpress.c
> index b615844..dbd6e6b 100644
> --- a/hw/vexpress.c
> +++ b/hw/vexpress.c
> @@ -426,10 +426,14 @@ static void vexpress_common_init(const VEDBoardInfo *daughterboard,
>      vmstate_register_ram_global(vram);
>      memory_region_add_subregion(sysmem, map[VE_VIDEORAM], vram);
>
> +    /* 0x4e000000 MMIO virtio transport */
> +    sysbus_create_simple("virtio-mmio", 0x4e000000, pic[42]);
>      /* 0x4e000000 LAN9118 Ethernet */
> -    if (nd_table[0].used) {
> -        lan9118_init(&nd_table[0], map[VE_ETHERNET], pic[15]);
> -    }
> +    /*
> +     *  if (nd_table[0].used) {
> +     *    lan9118_init(&nd_table[0], map[VE_ETHERNET], pic[15]);
> +     *  }
> +     */

why do we comment this out? we could just leave this as the default
option right? (after all we are emulating a vexpress board)

>
>      /* VE_USB: not modelled */
>
> --
> 1.7.11.4
>
> _______________________________________________
> kvmarm mailing list
> kvmarm@xxxxxxxxxxxxxxxxxxxxx
> https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux