Re: [PATCH v2 0/3] bootwrapper: Add support for big.LITTLE models

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 09, 2012 at 01:31:55PM +0100, Peter Maydell wrote:
> On 8 October 2012 14:59, Jon Medhurst (Tixy) <tixy@xxxxxxxxxx> wrote:
> > This mostly boils down to initialising the Cache Coherent Interconnect
> > (CCI). We do this by looking in the device-tree for a CCI node, that way
> > the same semihosting bootwrapper binary can be used on both the
> > big.LITTLE models and on the A15 models which don't have a CCI.
> >
> > Changes sinces v1:
> >  - Added in-source comment to configure_from_fdt()
> >  - Reworded commit message for patch 2
> >
> > [PATCH v2 1/3] bootwrapper: Allow for multiple clusters in boot CPU
> > [PATCH v2 2/3] bootwrapper: Factor out parsing of fdt #address-cells
> > [PATCH v2 3/3] bootwrapper: Initialise CCI device if found in the
> 
> All:
> Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
> and tested that the KVM boot is still OK.
> 
> Patch 2 made git complain about trailing whitespace in one place
> but I'll just zap that in passing when I apply these.

Thanks
 
> Dave, unless you have any further review comments I propose
> to apply these Wednesday.

Apart from a couple of minor stylistic quibbles, the look good to me.
Those aren't critical, but could be tweaked if you get a moment.

Cheers
---Dave
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux