On Mon, Oct 8, 2012 at 9:11 AM, KONRAD Frédéric
<fred.konrad@xxxxxxxxxxxxx> wrote:
> --- a/hw/vexpress.c 2012-10-03 14:09:00.000000000 +0200
> +++ b/hw/vexpress.c 2012-10-05 18:11:52.860712397 +0200
> @@ -322,6 +322,7 @@
>
> /* A15 daughterboard peripherals: */
>
> +
stray white space
> /* 0x20000000: CoreSight interfaces: not modelled */
> /* 0x2a000000: PL301 AXI interconnect: not modelled */
> /* 0x2a420000: SCC: not modelled */
> @@ -426,10 +427,12 @@
> vmstate_register_ram_global(vram);
> memory_region_add_subregion(sysmem, map[VE_VIDEORAM], vram);
>
> + /* 0x4e000000 MMIO virtio transport */
> + sysbus_create_simple("virtio-mmio", 0x4e000000, pic[42]);
> /* 0x4e000000 LAN9118 Ethernet */
> - if (nd_table[0].used) {
> + /*if (nd_table[0].used) {
> lan9118_init(&nd_table[0], map[VE_ETHERNET], pic[15]);
> - }
> + }*/
please don't add multi-line comments like this - it makes it really
hard to read in a diff. Consider using an #ifdef 0 for debugging or
temporary hacks, or do block like these:
/*
* xxx
* xxx
*/
just a few nits, thanks for the work so far!
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
