Re: [RFC PATCH 04/12] Virt-mmio test.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Oct 8, 2012, at 9:14 AM, Peter Maydell <peter.maydell@xxxxxxxxxx> wrote:

> On 8 October 2012 14:10, KONRAD Frédéric <fred.konrad@xxxxxxxxxxxxx> wrote:
>> --- a/hw/virtio.c    2012-10-08 11:12:12.211646215 +0200
>> +++ b/hw/virtio.c    2012-10-08 11:11:07.150391585 +0200
>> @@ -631,6 +631,12 @@
>>      return vdev->vq[n].pa;
>>  }
>> 
>> +void virtio_queue_set_num(VirtIODevice *vdev, int n, int num)
>> +{
>> +    vdev->vq[n].vring.num = num;
>> +    virtqueue_init(&vdev->vq[n]);
>> +}
>> +
> 
> Hi. Can you sort out the mechanism you're using to send patch emails,
> please? What you're doing at the moment seems to be losing the commit
> messages. (For instance, this mail is the same as this patch:
> http://lists.gnu.org/archive/html/qemu-devel/2012-09/msg02464.html
> but you've dropped the commit message/signed-off-by/authorship lines.)
> 
> I recommend a combination of git-format-patch and git-send-email
> for this: that can take a set of patches in git and send them out
> as emails in the way that people generally expect to see 


You can also use git send-email directly or consider using stgit if you're managing a branch that rebases. It would also be really nice if you could point to a public repo where we can pull these patches. 

Thanks!
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm



[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux