On Oct 2, 2012, at 5:16 AM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote: > On 01/10/12 19:47, Christoffer Dall wrote: >> On Mon, Oct 1, 2012 at 9:42 AM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote: >>> In order to be able to change the layout of struct kvm_cpu_regs, >>> introduce a separate set of macros that are used to save and >>> restore the host registers using the stack. >> >> the patch looks ok, but this text doesn't exactly motivate this change >> (or I'm incredibly slow, which means slow people like me should still >> be able to understand this). If you change the struct kvm_cpu_regs >> things would just be differently layed out on the stack, right? > > The point is to have different macros to save host and guest contexts. > Once you've separated things, you can start rearranging things easily. > Either way, the code is fine, I just didn't think the text accurately described the point, but this patch is going to be folded down anyway I suppose. _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
