On Mon, 2012-10-01 at 17:33 +0100, Dave Martin wrote:
> On Thu, Sep 27, 2012 at 07:06:20PM +0100, Jon Medhurst (Tixy) wrote:
> > + if (offset >= 0) {
> > + p = fdt_getprop(fdt, offset, "reg", &len);
> > + if(len != (addrcells + sizecells) * 4)
> > + info("Failed parsing device-tree node for CCI\n");
> > + else
> > + init_cci(fdt32_to_cpu(p[addrcells - 1]));
>
> I think this is worth a comment. I presume you're trying to get the low
> 32 bits of the address here (and assuming that the high 32 bits are zero).
That's correct. I've been assuming this bootwrapper is only good for
32-bit systems anyway, or am I mistake?
I'll add an appropriate comment either way.
Thanks for reviewing these patches.
--
Tixy
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
