Re: [PATCH v2 3/3] bootwrapper: Delay switch to Hyp mode until kernel entry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26 September 2012 15:12, Peter Maydell <peter.maydell@xxxxxxxxxx> wrote:
> On 26 September 2012 14:37, Peter Maydell <peter.maydell@xxxxxxxxxx> wrote:
>> On 6 September 2012 18:12, Dave Martin <dave.martin@xxxxxxxxxx> wrote:
>>> Signed-off-by: Dave Martin <dave.martin@xxxxxxxxxx>
>>
>> This patch causes the kernel to get stuck at "Calibrating delay loop...".
>>
>> I'm not sure why this happens (investigating) but if I move the
>> enter_hyp macro call back to where it used to be (leaving the rest of
>> the patch intact) it boots OK...
>
> ...hmm, no, seems to be a false alarm. I must not have recompiled
> properly or something, it works OK now. Sorry for the noise.

I was right the first time. The model runs really slowly because
CPU1+ have run off into the weeds. The patch has added an 'enter_hyp'
call into the chunk of code which is relocated to some random
address, which means the code is now too long and we only relocate
half of it. So when the primary CPU wakes up the secondaries they
just run off into the weeds. Solution: move the enter_hyp to before
the secondary-CPU pen code rather than after it.

Unless anybody objects I propose to commit these three bootwrapper
patches (with the above one-line fix) tomorrow.

-- PMM
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux