Re: [PATCH] bootwrapper: Use local definition of string.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2012-09-04 at 16:10 +0100, Peter Maydell wrote:
> On 4 September 2012 15:57, Jon Medhurst (Tixy) <tixy@xxxxxxxxxx> wrote:
> > diff --git a/string.h b/string.h
> > new file mode 100644
> > index 0000000..f1aebdf
> > --- /dev/null
> > +++ b/string.h
> > @@ -0,0 +1,16 @@
> > +#ifndef STRING_H
> > +#define STRING_H
> > +
> > +#include <stddef.h>
> 
> I guess to be fully consistent we should provide our own
> stddef.h and stdint.h, but if it's not causing problems it's
> not worth the effort.

That was my thinking, especially as the definitions might depend on
non-standard types and toolchain version - let sleeping dogs lie ;-)

> > +
> > +extern void *(memcpy)(void *__dest, __const void *__src, size_t __n);
> 
> I was going to complain about the weird parens around function
> names and inconsistent use of __ prefix on parameter names,
> but I see these all come straight from the existing string.c,
> so never mind :-)

Yes, I thought they looked weird too, but I just copied the non-static
function prototypes straight out of string.c.

-- 
Tixy

_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux