Re: [PATCH] KVM: ARM: Clarify comment on handle_exit.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 23, 2012 at 3:10 AM, Rusty Russell <rusty.russell@xxxxxxxxxx> wrote:
> If I'm reading the code right, > 0 loops around, < 0 exits with an error,
> and 0 returns to qemu.
>
> Signed-off-by: Rusty Russell <rusty.russell@xxxxxxxxxx>
>
> diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c
> index 09a6800..d4ee014 100644
> --- a/arch/arm/kvm/arm.c
> +++ b/arch/arm/kvm/arm.c
> @@ -504,8 +504,8 @@ static bool kvm_condition_valid(struct kvm_vcpu *vcpu)
>  }
>
>  /*
> - * Return 0 to return to guest, < 0 on error, exit_reason ( > 0) on proper
> - * exit to QEMU.
> + * Return > 0 to return to guest, < 0 on error, 0 (and set exit_reason) on
> + * proper exit to QEMU.
>   */
>  static int handle_exit(struct kvm_vcpu *vcpu, struct kvm_run *run,
>                        int exception_index)

absolutely right, thanks!
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux